Skip to content

Add testcase to confirm current link behaviour and add check if 'link' in options is instance of dict.#233

Open
mielvds wants to merge 5 commits into
masterfrom
link-circular-refs
Open

Add testcase to confirm current link behaviour and add check if 'link' in options is instance of dict.#233
mielvds wants to merge 5 commits into
masterfrom
link-circular-refs

Conversation

@mielvds
Copy link
Copy Markdown
Collaborator

@mielvds mielvds commented Jan 20, 2026 •
edited
Loading

This PR adds a testcase for link that confirms the current behaviour and adds a safeguard for non-dict values of options['link'] where applicable. An empty dict is not truthy in python, so cannot just check for "if options['link']". However, this in some places, this is desired.

Fixes #64
Replaces #66 because it was too outdated for a merge.

@mielvds mielvds mentioned this pull request Jan 20, 2026
Closed
@mielvds mielvds marked this pull request as draft January 20, 2026 12:53
@mielvds
Copy link
Copy Markdown
Collaborator Author

mielvds commented Jan 20, 2026 •
edited
Loading

This PR introduces a regression in the framing implementation. While the use of options['link'] is error-prone, the current code somehow relies on this side-effect. Further investigation is needed before this becomes an actual fix.

@mielvds mielvds force-pushed the link-circular-refs branch from 45b8b7f to fb443c1 Compare May 12, 2026 11:01
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 12, 2026 •
edited
Loading

Coverage

Coverage Report
FileStmtsMissCoverMissing
lib/pyld
   canon.py218498%27, 180, 565–566
   context_resolver.py102892%70, 129, 143, 189, 195–197, 221
   iri_resolver.py141398%307–308, 318
   jsonld.py244017093%274–278, 359, 396, 401, 411, 428–443, 479–480, 522, 530, 550, 558–559, 667–672, 752–753, 768–769, 829–834, 859–860, 875–876, 886–887, 913, 954, 964, 970–974, 985–986, 1019, 1028, 1035, 1100, 1123, 1145–1147, 1157–1160, 1175, 1198, 1210–1213, 1305, 1317–1320, 1340, 1369, 1402, 1406, 1443, 1486, 1505–1508, 1517, 1566, 1669–1676, 1703–1705, 1710, 1731–1734, 1910, 1948, 2381, 2390–2397, 2489, 2516, 2539, 2548, 3064, 3117, 3120, 3183, 3268, 3302, 3310, 3588, 3593, 3595, 3644, 3782–3786, 3852, 3889, 3952, 4187, 4475, 4609, 4643, 4672–4675, 4701–4702, 4885, 4949, 4976, 5050, 5052, 5070, 5168, 5217, 5449, 5451, 5490, 5492, 5501, 5640, 5768, 5855, 5975–5989, 6048–6054, 6121, 6334, 6340–6344, 6383, 6386, 6476–6477, 6486
lib/pyld/documentloader
   aiohttp.py652266%28–38, 69, 75, 87, 99–107, 118–121, 138, 153–155
   requests.py41588%55, 69, 81–89
TOTAL319321293% 

Tests Skipped Failures Errors Time
1674 51 💤 0 ❌ 0 🔥 2m 53s ⏱️

@mielvds mielvds force-pushed the link-circular-refs branch from fb443c1 to 5f34cad Compare May 13, 2026 10:56
@mielvds mielvds mentioned this pull request May 13, 2026
Closed
@mielvds mielvds marked this pull request as ready for review May 13, 2026 11:02
@mielvds mielvds force-pushed the link-circular-refs branch from c3e3548 to cf90813 Compare May 13, 2026 11:45
@mielvds mielvds changed the title Add check if 'link' in options is instance of dict. Add testcase to confirm current link behaviour and add check if 'link' in options is instance of dict. May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BigBlueHat BigBlueHat Awaiting requested review from BigBlueHat

@davidlehn davidlehn Awaiting requested review from davidlehn

@anatoly-scherbakov anatoly-scherbakov Awaiting requested review from anatoly-scherbakov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.0.0 (migration to rdflib)

Development

Successfully merging this pull request may close these issues.

framing with "@embed": "@link" cannot handle circular references

2 participants

@mielvds @anatoly-scherbakov